Federico Simoncelli has posted comments on this change. Change subject: Add transient disk support ......................................................................
Patch Set 2: (3 comments) .................................................... File vdsm/vm.py Line 1391: return False Line 1392: Line 1393: @property Line 1394: def blockDev(self): Line 1395: if self.networkDev or self.transientDisk: This should be automatic. Isn't self._blockDev = utils.isBlockDevice(self.path) going to be false anyway? Line 1396: return False Line 1397: Line 1398: if self._blockDev is None: Line 1399: try: Line 1418: # transient disks, since we create them in /var/run/vdsm which Line 1419: # may end up on tmpfs and don't support O_DIRECT, and qemu uses Line 1420: # O_DIRECT when cache=none and hence hotplug might fail with Line 1421: # error that one can take eternity to debug the reason behind it! Line 1422: self.cache = "writethrough" You probably need to update also the format to be always qcow2 (not sure if this is the relevant place though). Line 1423: Line 1424: # Set the path to the trPath. Ideally this should have worked, but Line 1425: # this changes the drives's path attribute and hotunplug fails to Line 1426: # to find the disk!. Alternative is to use the trPath as part of Line 3299: Line 3300: parentFmt = fmt2str(name2type(volInfo['info']['format'])) Line 3301: trPath = self._getTransientDiskPath(vpath) Line 3302: Line 3303: createVolume(parent, parentFmt, trPath, size, COW_FORMAT, I'm not sure we want this here. I was thinking of using a straight qemuImg.create(...). Line 3304: SPARSE_VOL, useRelPath=False) Line 3305: Line 3306: sdUUID = drive['domainID'] Line 3307: oop.getProcessPool(sdUUID).os.chmod(trPath, 0660) -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
