Federico Simoncelli has posted comments on this change. Change subject: vm: add the transient disk support ......................................................................
Patch Set 6: (2 comments) .................................................... File vdsm/vm.py Line 1424: # To handle legacy and removable drives. Line 1425: return False Line 1426: Line 1427: def _customize(self): Line 1428: if self.transientDisk: Note to self: remember to check this. Line 1429: # Force the cache to be writethrough, which is qemu's default. Line 1430: # This is done to ensure that we don't ever use cache=none for Line 1431: # transient disks, since we create them in /var/run/vdsm which Line 1432: # may end up on tmpfs and don't support O_DIRECT, and qemu uses Line 3398: # We lookup the drive by UUIDs since the image path could be Line 3399: # transient. Line 3400: drive = self._findDriveByUUIDs(diskParams) Line 3401: else: Line 3402: drive = self._findDriveByPath(diskParams['path']) Catch LookupError and transform to errCode['hotunplugDisk']. Line 3403: Line 3404: if drive.hasVolumeLeases: Line 3405: return errCode['noimpl'] Line 3406: -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
