Antoni Segura Puimedon has posted comments on this change. Change subject: Get rid of mutables(lists) as default parameters ......................................................................
Patch Set 1: (1 comment) Good catch Vinzenz! Thanks! .................................................... File vdsm/BindingXMLRPC.py Line 213: def vmCreate(self, vmParams): Line 214: vm = API.VM(vmParams['vmId']) Line 215: return vm.create(vmParams) Line 216: Line 217: def getVMList(self, fullStatus=False, vmList=None): Done Line 218: api = API.Global() Line 219: return api.getVMList(fullStatus, vmList) Line 220: Line 221: def vmPause(self, vmId): -- To view, visit http://gerrit.ovirt.org/18356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I911485cf30d587f5b6b8bf44cf3552c1517abfd5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
