Yaniv Bronhaim has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
......................................................................
Patch Set 20:
(4 comments)
....................................................
File vdsm/vdsmd.init.in
Line 66: ret_val=$?
Line 67: if [ "${ret_val}" -ne 0 ]; then
Line 68: log_failure_msg "${prog}: Stop conflicting ${srv}"
Line 69: return "${ret_val}"
Line 70: fi
why can't this be part of vdsm-tool service-disable?
Line 71: done
Line 72: return 0
Line 73: }
Line 74:
Line 102: if [ "${ret_val}" -ne 0 ]; then
Line 103: log_failure_msg "${prog}: Start dependent ${srv}"
Line 104: return "${ret_val}"
Line 105: fi
Line 106: done
same as above. service.py should treat all those cases, doesn't it ?
Line 107: }
Line 108:
Line 109: test_already_running()
Line 110: {
....................................................
File vdsm/vdsmd.service.in
Line 1: [Unit]
Line 2: Description=Virtual Desktop Server Manager
Line 3: Requires=multipathd.service libvirtd.service time-sync.target \
Line 4: iscsid.service rpcbind.service supervdsmd.service sanlock
regarding to https://bugzilla.redhat.com/show_bug.cgi?id=922795 , the required
declaration leads to the required services start when vdsmd is restarted
Line 5: Conflicts=libvirt-guests.service ksmtuned.service
Line 6:
Line 7: [Service]
Line 8: Type=simple
....................................................
File vdsm/vdsmd_init_common.sh.in
Line 29:
Line 30:
Line 31: task_gencerts(){
Line 32: if ! "@LIBEXECDIR@/vdsm-gencerts.sh" --check; then
Line 33: printf "Configuring a self-signed VDSM host certificate"
use echo
Line 34: "@LIBEXECDIR@/vdsm-gencerts.sh" || return 1
Line 35: fi
Line 36: return 0
Line 37: }
--
To view, visit http://gerrit.ovirt.org/15578
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Mei Liu <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
