Alon Bar-Lev has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
......................................................................
Patch Set 20:
(3 comments)
....................................................
File vdsm/vdsmd.init.in
Line 66: ret_val=$?
Line 67: if [ "${ret_val}" -ne 0 ]; then
Line 68: log_failure_msg "${prog}: Stop conflicting ${srv}"
Line 69: return "${ret_val}"
Line 70: fi
I prefer using downstream specific commands within pure downstream scripts, and
avoid the abstraction provided by vdsm.
Line 71: done
Line 72: return 0
Line 73: }
Line 74:
Line 102: if [ "${ret_val}" -ne 0 ]; then
Line 103: log_failure_msg "${prog}: Start dependent ${srv}"
Line 104: return "${ret_val}"
Line 105: fi
Line 106: done
it cannot, it does not run as root.
Line 107: }
Line 108:
Line 109: test_already_running()
Line 110: {
....................................................
File vdsm/vdsmd.service.in
Line 1: [Unit]
Line 2: Description=Virtual Desktop Server Manager
Line 3: Requires=multipathd.service libvirtd.service time-sync.target \
Line 4: iscsid.service rpcbind.service supervdsmd.service sanlock
yes, but this patch will rebased on your solution or your solution will be
rebased on this...
Line 5: Conflicts=libvirt-guests.service ksmtuned.service
Line 6:
Line 7: [Service]
Line 8: Type=simple
--
To view, visit http://gerrit.ovirt.org/15578
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Mei Liu <liu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
