Alon Bar-Lev has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
......................................................................
Patch Set 20:
(1 comment)
....................................................
File vdsm/vdsmd.init.in
Line 102: if [ "${ret_val}" -ne 0 ]; then
Line 103: log_failure_msg "${prog}: Start dependent ${srv}"
Line 104: return "${ret_val}"
Line 105: fi
Line 106: done
I did not understand what service.py is...
there is a different, I think, between a logic, such as libvirt configuration,
which is application specific anyway and the ability to maintain sane init.d
script.
what you are recommending is to place #ifdef for every distribution within the
vdsm code and provide abstraction for a functionality that does not require
abstraction.
It will also easier for downstream maintainer to maintain the initscript and
fix issues if exists if it is not tied within the application logic.
the vdsm-tool start/stop functionality is very handy as far as documentation is
concerned... you can have one command documented instead of per distribution...
it also easier to support people this way... as you do not ask them what distro
they are running, just tell them to execute vdsm-tool restart for example.
but when it comes down to actual maintenance these abstraction are harder to
understand.
Line 107: }
Line 108:
Line 109: test_already_running()
Line 110: {
--
To view, visit http://gerrit.ovirt.org/15578
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Mei Liu <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
