Michal Skrivanek has posted comments on this change.

Change subject: vdsm: Reboot capability for VM
......................................................................


Patch Set 19:

(1 comment)

....................................................
File vdsm/vm.py
Line 2413:     def shutdown(self, timeout, message, reboot=False, force=False):
Line 2414:         if reboot:
Line 2415:             # flag for successful reboot detection
Line 2416:             # set in onReboot handler
Line 2417:             self._rebootPerformed = False
I'd try to re-use the _guestEvent...that's what it is supposed to be for
Line 2418:             info = {'action': 'Reboot',
Line 2419:                     'guestEvent': 'RebootInProgress',
Line 2420:                     'returnMsg': 'Machine rebooting',
Line 2421:                     'qemuAgent': self._qemuAgentReboot,


-- 
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Martin Betak <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to