Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
......................................................................
Patch Set 19: Code-Review-1
(1 comment)
....................................................
File lib/vdsm/utils.py
Line 923: try:
Line 924: self.log.debug('Calling %s with args=%s and
kwargs=%s',
Line 925: self.func.__name__, self.args,
self.kwargs)
Line 926: self.func(*self.args, **self.kwargs)
Line 927: if self.timeout:
Please use a different variable name for this. This is misleading about what
'timeout' actually means and how it is used here.
Line 928: time.sleep(self.timeout)
Line 929: except self.ignored_exceptions:
Line 930: pass
Line 931: except Exception:
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Martin Betak <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
