Yaniv Bronhaim has uploaded a new change for review. Change subject: Removing automatic restart of services in libvirt-reconfigure ......................................................................
Removing automatic restart of services in libvirt-reconfigure libvirt-reconfigure also restarted libvirtd as post reconfigure operation. The restart is required but there is no reason and its not expected to perform it automatically as part of the reconfigure operation. Restart also required to supervdsmd service (as described in the Bug-Url). Instead of restarting both, this patch prints message to user to preform the restart manually. For backward compatibility with systemd, this also update systemd-vdsmd script to restart libvirtd and supervdsmd services in previous versions. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=999853 Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Signed-off-by: Yaniv Bronhaim <[email protected]> --- M init/systemd/systemd-vdsmd.in M lib/vdsm/tool/libvirt_configure.sh.in 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/18780/1 diff --git a/init/systemd/systemd-vdsmd.in b/init/systemd/systemd-vdsmd.in index cf20b84..1fcb67b 100644 --- a/init/systemd/systemd-vdsmd.in +++ b/init/systemd/systemd-vdsmd.in @@ -27,3 +27,5 @@ [ -n "$2" -a "$2" != "force" ] && usage_exit "@BINDIR@/vdsm-tool" libvirt-configure ${2:+--force} +"@BINDIR@/vdsm-tool" service-restart libvirtd +"@BINDIR@/vdsm-tool" service-restart supervdsmd diff --git a/lib/vdsm/tool/libvirt_configure.sh.in b/lib/vdsm/tool/libvirt_configure.sh.in index 3a4f4fa..5103b5b 100755 --- a/lib/vdsm/tool/libvirt_configure.sh.in +++ b/lib/vdsm/tool/libvirt_configure.sh.in @@ -282,7 +282,10 @@ ovirt_store_config "${lconf}" "${qconf}" "${ldconf}" "${llogr}" fi - /usr/bin/vdsm-tool service-restart libvirtd + echo "Reconfigure libvirt is done." + echo "To start using new configuration please restart libvirtd and supervdsmd services:" + echo "['vdsm-tool service-restart libvirtd']" + echo "['vdsm-tool service-restart supervdsmd']" # # finished reconfiguration, do not trigger -- To view, visit http://gerrit.ovirt.org/18780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
