Zhou Zheng Sheng has posted comments on this change.

Change subject: Removing automatic restart of services in libvirt-reconfigure
......................................................................


Patch Set 1:

What will happen when a fresh installed vdsm service is started by the user? 
Does the configuration change become effective without restart? I think it's 
good to split the reconfigure and restart into two step. When 
libvirt-reconfigure is called, just configure but no restart. Then in VDSM SysV 
script or vdsmd_init_common it can restart the related services after a 
configuration change.

-- 
To view, visit http://gerrit.ovirt.org/18780
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to