Yaniv Bronhaim has posted comments on this change.
Change subject: Removing automatic restart of services in libvirt-reconfigure
......................................................................
Patch Set 1:
(2 comments)
The caller to libvirt_reconfigure should handle the restarts..
If we want that "service vdsmd reconfigure" will perform the restarts, we
should add it after the call to "vdsm-tool reconfigure" (in vdsmd.init script).
But still, I think that the caller to "service vdsmd reconfigure" should
perform the restarts manually when needed.
....................................................
File init/systemd/systemd-vdsmd.in
Line 26: [ "$1" != "reconfigure" ] && usage_exit
Line 27: [ -n "$2" -a "$2" != "force" ] && usage_exit
Line 28:
Line 29: "@BINDIR@/vdsm-tool" libvirt-configure ${2:+--force}
Line 30: "@BINDIR@/vdsm-tool" service-restart libvirtd
the script uses libvirt_configure.sh for that.. i updated there.
....................................................
File lib/vdsm/tool/libvirt_configure.sh.in
Line 283: fi
Line 284:
Line 285: echo "Reconfigure libvirt is done."
Line 286: echo "To start using new configuration please restart libvirtd
and supervdsmd services:"
Line 287: echo "['vdsm-tool service-restart libvirtd']"
you can.. but then you'll need to restart suprevdsm again, ill change the order
Line 288: echo "['vdsm-tool service-restart supervdsmd']"
Line 289:
Line 290: #
Line 291: # finished reconfiguration, do not trigger
--
To view, visit http://gerrit.ovirt.org/18780
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
