Federico Simoncelli has posted comments on this change.

Change subject: vm: add the transient disk support
......................................................................


Patch Set 7:

(1 comment)

....................................................
File vdsm/vm.py
Line 3384:                 # We lookup the drive by UUIDs since the image path 
could
Line 3385:                 # be transient.
Line 3386:                 drive = self._findDriveByUUIDs(diskParams)
Line 3387:             else:
Line 3388:                 drive = self._findDriveByPath(diskParams['path'])
This doesn't mix well in case we want a transient LUN disk.
Line 3389:         except LookupError:
Line 3390:             self.log.error("Hotunplug disk failed - Disk not found: 
%s",
Line 3391:                            diskParams)
Line 3392:             return {'status': {


-- 
To view, visit http://gerrit.ovirt.org/18326
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to