Antoni Segura Puimedon has posted comments on this change. Change subject: netconf: Sort bond's slave when objectivizing ......................................................................
Patch Set 1: Code-Review-1 I guess configureBond of iproute2.py could do it as well, but I don't really mind doing it here as the sorting cost of the amount of nics that are typically enslaved to a bond is rather small. However, I'd like a comment above the line that explains the reason for the sorting, e.g., "Sorting nics in order to have a deterministic slave list for the same slaves". -- To view, visit http://gerrit.ovirt.org/19591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
