Mark Wu has posted comments on this change.

Change subject: netconf: Sort bond's slave when objectivizing
......................................................................


Patch Set 3:

(1 comment)

....................................................
File vdsm/netmodels.py
Line 389:     to bonding in the same order that initscripts does it. Then it can
Line 390:     obtain the same master mac address by iproute2 as ifcfg.
Line 391:     """
Line 392: 
Line 393:     nics_list = []
Good catch!  I will fix it in next patch.
Line 394:     nics_rexp = re.compile("^(\D*)(\d*)(.*)$")
Line 395: 
Line 396:     for nic_name in nics:
Line 397:         nic_sre = nics_rexp.match(nic_name)


-- 
To view, visit http://gerrit.ovirt.org/19591
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to