Dan Kenigsberg has posted comments on this change. Change subject: netconf: Sort bond's slave when objectivizing ......................................................................
Patch Set 2: Code-Review-1 (2 comments) .................................................... Commit Message Line 8: Line 9: To make iproute2 configurator pass testBondHwAddress, we need keep Line 10: the bond's slaves sorted. Otherwise bond's hwaddr will vary with the Line 11: order of enslaving. This work is done by initscript for ifcfg Line 12: configurator. Do we mind that the slave order would depend on the configurator identity? ifcfg uses a more complex storting function, which we used to imitate in vdsm. grep for 'def nicSort'. Line 13: Line 14: Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae .................................................... File vdsm/netmodels.py Line 234: def objectivize(cls, name, configurator, options, nics, mtu, _netinfo, Line 235: destroyOnMasterRemoval=None): Line 236: if name and nics: # New bonding or edit bonding. Line 237: """ Line 238: Sorting nics in order to have a deterministic slave list for the why is it a string instead of a plain comment? Line 239: same slaves Line 240: """ Line 241: slaves = cls._objectivizeSlaves(name, configurator, sorted(nics), Line 242: mtu, _netinfo) -- To view, visit http://gerrit.ovirt.org/19591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
