Dan Kenigsberg has posted comments on this change.
Change subject: Manage and fix test dummies handling -> module level
......................................................................
Patch Set 9:
(2 comments)
....................................................
File tests/functional/networkTests.py
Line 539: setupNetworkBridged(nics[0], True)
Line 540: setupNetworkBridged(nics[0], False)
Line 541: setupNetworkBridged(nics[0], True)
Line 542:
Line 543: status, msg = self.vdsm_net.setupNetworks({NETWORK_NAME:
good catch
Line 544:
dict(remove=True)},
Line 545: {}, opts)
Line 546:
Line 547: self.assertEqual(status, SUCCESS, msg)
Line 1259: ruleAdd(rule)
Line 1260: self.assertTrue(ruleExists(rule))
Line 1261: ruleDel(rule)
Line 1262: self.assertFalse(ruleExists(rule))
Line 1263: addrFlush(nic)
how is this related to this patch?
Line 1264:
Line 1265: @RequireDummyMod
Line 1266: @ValidateRunningAsRoot
Line 1267: def testRouteExists(self):
--
To view, visit http://gerrit.ovirt.org/19650
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c040fc3175b5760728d749578728be60c75cb9b
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
