Antoni Segura Puimedon has posted comments on this change. Change subject: Manage and fix test dummies handling -> module level ......................................................................
Patch Set 9: (1 comment) .................................................... File tests/functional/networkTests.py Line 1259: ruleAdd(rule) Line 1260: self.assertTrue(ruleExists(rule)) Line 1261: ruleDel(rule) Line 1262: self.assertFalse(ruleExists(rule)) Line 1263: addrFlush(nic) Because this patch makes dummy nics be reused across the module. Before it, each test got newly created dummy interfaces, so that no ip address cleanup was necessary. However, now, if you were to get the same nic in testRuleExists and testRouteExists, the test would be skipped when setIP would fail on EEXISTS for the IP address. Line 1264: Line 1265: @RequireDummyMod Line 1266: @ValidateRunningAsRoot Line 1267: def testRouteExists(self): -- To view, visit http://gerrit.ovirt.org/19650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c040fc3175b5760728d749578728be60c75cb9b Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
