Yaniv Bronhaim has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement - vdsClient
......................................................................
Patch Set 1:
(3 comments)
....................................................
File lib/vdsm/vdscli.py.in
Line 49: result = func(*args, **kwargs)
Line 50: else:
Line 51: result = func(self._transport, *args, **kwargs)
Line 52: except ExpatError as e:
Line 53: print ('Parsing error thrown during parsing response. '
was thrown
Line 54: 'Following arguments were passed:')
Line 55: for name, value in kwargs.items():
Line 56: print '{0} = {1}'.format(name, value)
Line 57: raise e
Line 52: except ExpatError as e:
Line 53: print ('Parsing error thrown during parsing response. '
Line 54: 'Following arguments were passed:')
Line 55: for name, value in kwargs.items():
Line 56: print '{0} = {1}'.format(name, value)
better to use sys.stdout\stderr than print
Line 57: raise e
Line 58: return result
Line 59:
Line 60:
Line 169:
Line 170: transport = TransportClass(key_file=KEYFILE,
Line 171: cert_file=CERTFILE,
ca_certs=CACERT)
Line 172: server = xmlrpclib.ServerProxy('https://%s' % hostPort,
Line 173:
TransportWrapper(transport=transport))
you can just pass transport object (no need for transport=transport explicitly)
Line 174: else:
Line 175: transport = TransportWrapper(SingleRequestTransport())
Line 176: server = xmlrpclib.Server('http://%s' % hostPort,
Line 177: transport=transport)
--
To view, visit http://gerrit.ovirt.org/20627
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife29c4f7749b9cd8a4ad892f486d91509e505ae4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
