Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: Parsing error logging enhancement - vdsClient ......................................................................
Patch Set 3: Code-Review-1 (2 comments) .................................................... Commit Message Line 5: CommitDate: 2013-11-04 09:44:48 +0100 Line 6: Line 7: xmlrpc: Parsing error logging enhancement - vdsClient Line 8: Line 9: Logging enhancement which help to understand the issues during English mistake stays. You should say "which helps understand the issues..." Line 10: parsing xml response obtained from vdsm. Parsing Line 11: issues can occur when bad characters are in xml etc. Line 12: Line 13: In order to get raw response we need to wrap transport class .................................................... File lib/vdsm/vdscli.py.in Line 40: Line 41: def __getattr__(self, name): Line 42: if hasattr(self._transport, name): Line 43: func = getattr(self._transport, name) Line 44: return lambda *args, **kwargs: self._wrap(name, func, args, kwargs) Please answer: which method(s) is(are) expected to raise ExpatError? I'd rather be more specific and wrap only the thing we need. Line 45: raise AttributeError(name) Line 46: Line 47: def _wrap(self, name, func, args, kwargs): Line 48: try: -- To view, visit http://gerrit.ovirt.org/20627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife29c4f7749b9cd8a4ad892f486d91509e505ae4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
