Nir Soffer has posted comments on this change.

Change subject: Improve err msg when multipath cant access a pv
......................................................................


Patch Set 2:

> Nir, I disagree. The name no longer (or was ever) fits the content and IMO 
> has to change within this scope.

I'm still not sure about it - invalid device is the error, engine ask to do 
something with "foo" but there is no such device. Seems valid to me.

"Multipath cannot access pyhsical device: foo" is the error reason.

Inaccessible device may be "there is such device but I cannot access it".

I'm sure that this rename is not needed to fix this bug.

-- 
To view, visit http://gerrit.ovirt.org/21089
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to