Dan Kenigsberg has posted comments on this change. Change subject: Improve err msg when multipath cant access a pv ......................................................................
Patch Set 2: (2 comments) .................................................... File vdsm/storage/hsm.py Line 2037: in multipath.getMPDevNamesIter()) Line 2038: size = 0 Line 2039: devices = [] Line 2040: Line 2041: for dev in devlist: I share Nir's opinion about the exception name and text changes. More important to give fuller information, and use simpler and quicker set operations. devlist = set(devlist) devices = devlist & knowndevs unknown = devlist - knowndevs if unknown: raise whatever(unknown) Line 2042: if dev in knowndevs: Line 2043: devices.append(dev) Line 2044: size += multipath.getDeviceSize(devicemapper.getDmId(dev)) Line 2045: else: .................................................... File vdsm/storage/storage_exception.py Line 1456: class InaccessiblePhysDev(StorageException): Line 1457: def __init__(self, pvname): Line 1458: self.value = "pvname=%s" % (pvname) Line 1459: code = 606 Line 1460: message = "Multipath cannot access storage device" ...and "pvname" may be wrong as well. We look for luns, to make pvs out of them. Line 1461: Line 1462: Line 1463: class PartitionedPhysDev(StorageException): Line 1464: code = 607 -- To view, visit http://gerrit.ovirt.org/21089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
