Assaf Muller has posted comments on this change. Change subject: Add unit tests for unified network persistence ......................................................................
Patch Set 4: (2 comments) .................................................... File tests/netconfpersistenceTests.py Line 32: BONDING = 'skywalker' Line 33: BONDING_ATTRIBUTES = {'options': 'mode=4 miimon=100', 'nics': ['eth0', 'eth1']} Line 34: Line 35: Line 36: class netConfPersistenceTests(TestCaseBase): Done Line 37: def setUp(self): Line 38: self.tempdir = tempfile.mkdtemp() Line 39: os.mkdir(os.path.join(self.tempdir, 'nets')) Line 40: os.mkdir(os.path.join(self.tempdir, 'bonds')) Line 43: rmtree(self.tempdir) Line 44: Line 45: def testInit(self): Line 46: try: Line 47: filePath = os.path.join(self.tempdir, 'nets', NETWORK) Done Line 48: with open(filePath, 'w') as networkFile: Line 49: json.dump(NETWORK_ATTRIBUTES, networkFile) Line 50: Line 51: persistence = Config(self.tempdir) -- To view, visit http://gerrit.ovirt.org/21269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0221f2e0313a80d0ed5ce2d5406dc45f08ab26dd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches