Assaf Muller has posted comments on this change.
Change subject: Add unit tests for unified network persistence
......................................................................
Patch Set 4:
(1 comment)
....................................................
File tests/netconfpersistenceTests.py
Line 50:
Line 51: persistence = Config(self.tempdir)
Line 52: self.assertEqual(persistence.networks[NETWORK],
NETWORK_ATTRIBUTES)
Line 53: finally:
Line 54: os.remove(filePath)
If I do:
with open(...):
try:
pass
finally:
os.remove(...)
Then I'd fail to remove an open file...
I can just use utils.rmFile.
Line 55:
Line 56: def testSetAndRemoveNetwork(self):
Line 57: persistence = Config(self.tempdir)
Line 58: persistence.setNetwork(NETWORK, NETWORK_ATTRIBUTES)
--
To view, visit http://gerrit.ovirt.org/21269
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0221f2e0313a80d0ed5ce2d5406dc45f08ab26dd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
