Dan Kenigsberg has posted comments on this change. Change subject: Add unit tests for unified network persistence ......................................................................
Patch Set 4: (1 comment) .................................................... File tests/netconfpersistenceTests.py Line 50: Line 51: persistence = Config(self.tempdir) Line 52: self.assertEqual(persistence.networks[NETWORK], NETWORK_ATTRIBUTES) Line 53: finally: Line 54: os.remove(filePath) oh, and if open(filePath, 'w') fails, you'd have nothing to remove. so the "try" should open only within the scope of "with". Line 55: Line 56: def testSetAndRemoveNetwork(self): Line 57: persistence = Config(self.tempdir) Line 58: persistence.setNetwork(NETWORK, NETWORK_ATTRIBUTES) -- To view, visit http://gerrit.ovirt.org/21269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0221f2e0313a80d0ed5ce2d5406dc45f08ab26dd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
