Ayal Baron has posted comments on this change.

Change subject: sp: encapsulate spm status in StoragePool
......................................................................


Patch Set 7:

(1 comment)

....................................................
File vdsm/storage/sp.py
Line 167:     @unsecured
Line 168:     def forceFreeSpm(self):
Line 169:         # DO NOT USE, STUPID, HERE ONLY FOR BC
Line 170:         # TODO: SCSI Fence the 'lastOwner'
Line 171:         self.setSpmStatus(LVER_INVALID, SPM_ID_FREE)
this code can't work without securityOverride=True
Line 172:         self.spmRole = SPM_FREE
Line 173: 
Line 174:     def _upgradePoolDomain(self, sdUUID, isValid):
Line 175:         # This method is called everytime the onDomainStateChange


-- 
To view, visit http://gerrit.ovirt.org/21527
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b71349e2a0dfc453b68cd2d9ca6c563b1bee90c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to