Dan Kenigsberg has posted comments on this change. Change subject: sp: encapsulate spm status in StoragePool ......................................................................
Patch Set 8: (1 comment) .................................................... File vdsm/storage/sp.py Line 154: # default we override the security for setMetaParams. Line 155: # NOTE: this introduces a race when the method is used in the Line 156: # secured mode, but generally you shouldn't need to call this at Line 157: # any time. Line 158: self.setMetaParams(metaParams, __securityOverride=True) this seems to be the only remaining usage of setMetaParams(). How about inlining and removing it? Line 159: Line 160: @unsecured Line 161: def forceFreeSpm(self): Line 162: # DO NOT USE, STUPID, HERE ONLY FOR BC -- To view, visit http://gerrit.ovirt.org/21527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b71349e2a0dfc453b68cd2d9ca6c563b1bee90c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
