Ayal Baron has posted comments on this change. Change subject: sp: move reconnection info check to StoragePool ......................................................................
Patch Set 8: (2 comments) .................................................... File vdsm/storage/hsm.py Line 1040: else: Line 1041: pool.update(hostID, scsiKey, msdUUID, masterVersion) Line 1042: return True Line 1043: Line 1044: pool = sp.StoragePool(spUUID, self.domainMonitor, self.taskMng) why is it ok to not add pool.update here? Line 1045: Line 1046: # Must register domain state change callbacks *before* connecting Line 1047: # the pool, which starts domain monitor threads. Otherwise we will Line 1048: # miss the first event from the monitor thread. .................................................... File vdsm/storage/sp.py Line 677: f.writelines(pers) Line 678: Line 679: @unsecured Line 680: def getPoolParams(self, hostID, scsiKey, msdUUID, masterVersion): Line 681: if all((hostID, scsiKey, msdUUID, masterVersion)): I still hate this behaviour Line 682: return hostID, scsiKey, msdUUID, masterVersion Line 683: Line 684: self.log.info( Line 685: "Using saved connection parameters: hostID=%s, scsiKey=%s, " -- To view, visit http://gerrit.ovirt.org/21424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia57afc04db02b6c15633d09349a55b3ff5ae7fda Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
