Sergey Gotliv has posted comments on this change. Change subject: sp: move reconnection info check to StoragePool ......................................................................
Patch Set 8: (1 comment) Please, check if my suggestion in hsm.py is doable. .................................................... File vdsm/storage/hsm.py Line 1028: pass # pool not connected yet Line 1029: else: Line 1030: with rmanager.acquireResource(STORAGE, spUUID, rm.LockType.shared): Line 1031: self.getPool(spUUID).update(hostID, scsiKey, msdUUID, Line 1032: masterVersion) The problem described below is already exists before that patch, so I will completely understand if you will ignore it. The problem: In this case connectStoragePool detects that this host is already connected to the pool, but it still has to verify links to all storage domains. Let's assume that host (HSM) is a "Non Operational" which means it connected to pool but its not connected to one of its storage domains. When this connectivity issue is resolved the Engine tries to send "connectStoragePool" but since the pool is already connected VDSM doesn't try to check/restore links to the storage domains... And this logic is skipped without any log message. The problem I described above is real and easily reproducible, I can even reffer to the bug. 1. I would like to see the log message here that the pool is already connected. OR even better: 2. let's call refresh of links from update! Line 1033: return True Line 1034: Line 1035: with rmanager.acquireResource(STORAGE, spUUID, rm.LockType.exclusive): Line 1036: try: -- To view, visit http://gerrit.ovirt.org/21424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia57afc04db02b6c15633d09349a55b3ff5ae7fda Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
