Hello Ayal Baron, Bala.FA, Saggi Mizrahi, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/23057
to review the following change.
Change subject: gluster: enhance vdsmcli error handling
......................................................................
gluster: enhance vdsmcli error handling
Vdsmcli also treated as a functional testing tool. Checking
the functional parameter could hide the state of depending
function. Engine might call those functions without these
parameters also. So the parameter null check should go inside
the gluster function.
Change-Id: I2e29dfb724cf4c8370bf836d64510376df37058a
Signed-off-by: Timothy Asir <[email protected]>
---
M client/vdsClientGluster.py
1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/23057/1
diff --git a/client/vdsClientGluster.py b/client/vdsClientGluster.py
index dc8bd52..774b61d 100644
--- a/client/vdsClientGluster.py
+++ b/client/vdsClientGluster.py
@@ -420,9 +420,6 @@
raise ValueError
action = params.get('action', '')
- if not serviceNames or action == "":
- raise ValueError
-
status = self.s.glusterServicesAction(serviceNames, action)
pp.pprint(status)
return status['status']['code'], status['status']['message']
@@ -432,9 +429,6 @@
try:
serviceNames = params.get('serviceNames', '').split(',')
except:
- raise ValueError
-
- if not serviceNames:
raise ValueError
status = self.s.glusterServicesGet(serviceNames)
--
To view, visit http://gerrit.ovirt.org/23057
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e29dfb724cf4c8370bf836d64510376df37058a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
