Timothy Asir has posted comments on this change. Change subject: gluster: enhance vdsmcli error handling ......................................................................
Patch Set 1: -Verified (2 comments) http://gerrit.ovirt.org/#/c/23057/1/client/vdsClientGluster.py File client/vdsClientGluster.py: Line 416: params = self._eqSplit(args) Line 417: try: Line 418: serviceNames = params.get('serviceNames', '').split(',') Line 419: except: Line 420: raise ValueError > try/except is not required as its not going to return any exception from pa Done Line 421: action = params.get('action', '') Line 422: Line 423: status = self.s.glusterServicesAction(serviceNames, action) Line 424: pp.pprint(status) Line 427: def do_glusterServicesGet(self, args): Line 428: params = self._eqSplit(args) Line 429: try: Line 430: serviceNames = params.get('serviceNames', '').split(',') Line 431: except: > as like above try/except is not required. Also indentation has to be taken Done Line 432: raise ValueError Line 433: Line 434: status = self.s.glusterServicesGet(serviceNames) Line 435: pp.pprint(status) -- To view, visit http://gerrit.ovirt.org/23057 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e29dfb724cf4c8370bf836d64510376df37058a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <[email protected]> Gerrit-Reviewer: Aravinda VK <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Humble Devassy Chirammal <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
