Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster: enhance vdsmcli error handling ......................................................................
gluster: enhance vdsmcli error handling Vdsmcli also treated as a functional testing tool. Checking the functional parameter could hide the state of depending function. Engine might call those functions without these parameters also. So the parameter null check should go inside the gluster function. Change-Id: I2e29dfb724cf4c8370bf836d64510376df37058a Signed-off-by: Timothy Asir <[email protected]> Reviewed-on: http://gerrit.ovirt.org/23057 Reviewed-by: Bala.FA <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M client/vdsClientGluster.py 1 file changed, 9 insertions(+), 42 deletions(-) Approvals: Timothy Asir: Verified Bala.FA: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23057 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e29dfb724cf4c8370bf836d64510376df37058a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <[email protected]> Gerrit-Reviewer: Aravinda VK <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Humble Devassy Chirammal <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
