Nir Soffer has posted comments on this change. Change subject: vm: Update LUN size when starting a vm ......................................................................
Patch Set 5: (4 comments) .................................................... Commit Message Line 13: Hence, added the following information to disks stats for Line 14: DirectLUN disks: truesize, apparentsize and lunGUID Line 15: (the sizes values already exist but are zeroed). Line 16: Using these values, the engine could keep the DB updated. Line 17: This message must describe the suggested solution - adding support for getVolumeSize to be called with one positional parameter instead of four, handling one parameter as deviceGUID. Line 18: The following changes are introduced: Line 19: Line 20: * hsm: Line 21: Added getDeviceSize for fetching LUN's device size Line 17: Line 18: The following changes are introduced: Line 19: Line 20: * hsm: Line 21: Added getDeviceSize for fetching LUN's device size There is no such method in this patch set. Line 22: using multipath -> getDeviceSize. Line 23: Line 24: * clientIF: Line 25: For LUN devices, updated drive's truesize/apparentsize Line 22: using multipath -> getDeviceSize. Line 23: Line 24: * clientIF: Line 25: For LUN devices, updated drive's truesize/apparentsize Line 26: using getDeviceSize method. No such call is made. Line 27: Line 28: * vm: Line 29: _getDiskStats -> in order to identify each LUN Line 30: (e.g. on engine side), added 'lunGUID' to dStats .................................................... File vdsm/storage/hsm.py Line 2991: sdUUID=sdUUID).produceVolume(imgUUID=imgUUID, Line 2992: volUUID=volUUID).refreshVolume() Line 2993: Line 2994: @public Line 2995: def getVolumeSize(self, *args): This must be documented in vdsmapi-schema.json - not sure if the current schema supports such usage. Line 2996: if len(args) == 1: Line 2997: return self._getLUVolumeSize(args[0]) Line 2998: else: Line 2999: return self._getPDIVSize(args[0], args[1], args[2], args[3]) -- To view, visit http://gerrit.ovirt.org/22976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48b4343c6519fed366beec415c47226d4e3c8fef Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
