Nir Soffer has posted comments on this change.

Change subject: vm: Update LUN size when starting a vm
......................................................................


Patch Set 5:

(1 comment)

....................................................
File vdsm/storage/hsm.py
Line 2991:             sdUUID=sdUUID).produceVolume(imgUUID=imgUUID,
Line 2992:                                          
volUUID=volUUID).refreshVolume()
Line 2993: 
Line 2994:     @public
Line 2995:     def getVolumeSize(self, *args):
And of course this must be documented here in the docstring, and not in the 
docstring of _getLUVolumeSize and _getPDIVSize as these are private methods.
Line 2996:         if len(args) == 1:
Line 2997:             return self._getLUVolumeSize(args[0])
Line 2998:         else:
Line 2999:             return self._getPDIVSize(args[0], args[1], args[2], 
args[3])


-- 
To view, visit http://gerrit.ovirt.org/22976
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48b4343c6519fed366beec415c47226d4e3c8fef
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to