Nir Soffer has posted comments on this change. Change subject: core: Add boot time to the getVdsStats API ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/25877/11//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-04-02 16:18:47 +0300 Line 6: Line 7: core: Add boot time to the getVdsStats API Line 8: Line 9: Read boot time from /proc/stat and report in host stats Why add a constant string (boot time never changes) in a response about statistics? This made sense when we were returning the uptime, but not for boot time. It seems that this value should returned in a request that is done once, like getVdsCaps. This will also remove the need for caching this value, so we can drop half of the ocde. Line 10: Line 11: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1070348 Line 12: Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6 -- To view, visit http://gerrit.ovirt.org/25877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
