Dima Kuznetsov has posted comments on this change. Change subject: core: Add boot time to the getVdsStats API ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/25877/12/vdsm/sampling.py File vdsm/sampling.py: Line 451: # include it in the response. Line 452: try: Line 453: return getBootTime() Line 454: except (IOError, ValueError): Line 455: self._log.error('Failed to get boot time', exc_info=True) > You forgot Federico's suggestion, of using exception() instread of error(). I think it is best to handle the exception the way other exceptions are handled in this code, with: log.error(exc_info=True) Line 456: return None Line 457: Line 458: def get(self): Line 459: stats = self._getInterfacesStats() -- To view, visit http://gerrit.ovirt.org/25877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
