Federico Simoncelli has posted comments on this change. Change subject: core: Add boot time to the getVdsStats API ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/25877/11/vdsm/sampling.py File vdsm/sampling.py: Line 452: # include it in the response. Line 453: try: Line 454: return getBootTime() Line 455: except (IOError, ValueError) as e: Line 456: self._log.error('Failed to get boot time: %s', e) > use exc_info=True instead of e. even better would be to use self._log.exception(...) Line 457: return None Line 458: Line 459: def get(self): Line 460: stats = self._getInterfacesStats() -- To view, visit http://gerrit.ovirt.org/25877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
