Dan Kenigsberg has posted comments on this change. Change subject: recovery: try to restore VMs from recovery files ......................................................................
Patch Set 9: Code-Review+1 (3 comments) Some comments on the test http://gerrit.ovirt.org/#/c/25276/9/tests/functional/vmRecoveryTests.py File tests/functional/vmRecoveryTests.py: Line 33: Line 34: from utils import SUCCESS Line 35: Line 36: Line 37: def vdsm_start(wait_secs=5): We have ensure_vdsm_running, so why wait here Line 38: service_start('vdsmd') Line 39: start = time.time() Line 40: while time.time() - start < wait_secs and service_status('vdsmd'): Line 41: time.sleep(1) Line 88: vms = [] Line 89: for i in range(1, num + 1): Line 90: vm = VMProxy(self.vdsm, customizer(i)) Line 91: vm.start() Line 92: self._waitForBoot(vm.id) The test could be a bit quicker if you run both vms first, and wait for both later. Line 93: vms.append(vm) Line 94: Line 95: try: Line 96: yield vms Line 113: # #1 disappears: Line 114: # it goes down while VDSM is down: must be reported as down. Line 115: with self.running_vms(2, customize_vm) as vms: Line 116: os.kill(vms[0].pid, signal.SIGTERM) Line 117: time.sleep(1) # just to make sure "To be sure" you must waitForDown Line 118: Line 119: stats_before = vms[0].stats() Line 120: Line 121: pid = vms[1].pid -- To view, visit http://gerrit.ovirt.org/25276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id495f6047ba658c2b04da19bd7bf76425b3b9659 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
