Francesco Romani has posted comments on this change.
Change subject: recovery: try to restore VMs from recovery files
......................................................................
Patch Set 10:
I had a look at the engine code. Still not 100% confident, but I'm under the
impression the engine can misread the new condition we are possible reporting
here, from
{ [host::A, VM::A(UP)] }
to
{ [host::B, VM::A(UP)] }, { [host::B, VM::A(DOWN)] }
e.g. because someone manually migrated the VM while VDSM was down
To be specific, I'm concerned about the VM being reported as Down
on the previous host, a condition which IIUC was never presented before this
patch; the "disappearing VM" scenario was different, with VM suddenly changing
host but without such status change.
So I'd like to have the feedback from an engine expert before to go on. If the
VM is not moved AFAIK everything should work as expected.
--
To view, visit http://gerrit.ovirt.org/25276
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id495f6047ba658c2b04da19bd7bf76425b3b9659
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
