Vinzenz Feenstra has uploaded a new change for review. Change subject: agent: Only forward desktopLogin when the agent is responsive ......................................................................
agent: Only forward desktopLogin when the agent is responsive Change-Id: Ie1c65304319df949795ec0906df1343a43129641 Signed-off-by: Vinzenz Feenstra <[email protected]> --- M vdsm/virt/guestagent.py 1 file changed, 13 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/27147/1 diff --git a/vdsm/virt/guestagent.py b/vdsm/virt/guestagent.py index 5098da1..5e78b36 100644 --- a/vdsm/virt/guestagent.py +++ b/vdsm/virt/guestagent.py @@ -353,16 +353,19 @@ self.log.error("desktopLock failed", exc_info=True) def desktopLogin(self, domain, user, password): - try: - self.log.debug("desktopLogin called") - if domain != '': - username = user + '@' + domain - else: - username = user - self._forward('login', {'username': username, - "password": password}) - except: - self.log.error("desktopLogin failed", exc_info=True) + if self.isResponsive(): + try: + self.log.debug("desktopLogin called") + if domain != '': + username = user + '@' + domain + else: + username = user + self._forward('login', {'username': username, + "password": password}) + except: + self.log.error("desktopLogin failed", exc_info=True) + else: + self.log.info("desktopLogin called but guest agent not responsive") def desktopLogoff(self, force): try: -- To view, visit http://gerrit.ovirt.org/27147 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie1c65304319df949795ec0906df1343a43129641 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
