Vinzenz Feenstra has posted comments on this change. Change subject: agent: Only forward desktopLogin when the agent is responsive ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27147/1/vdsm/virt/guestagent.py File vdsm/virt/guestagent.py: Line 364: "password": password}) Line 365: except: Line 366: self.log.error("desktopLogin failed", exc_info=True) Line 367: else: Line 368: self.log.info("desktopLogin called but guest agent not responsive") > Maybe a warning is better here? Not a big deal however. Well there's no sense in having a warning here. Engine was modified to always send the login request now. Line 369: Line 370: def desktopLogoff(self, force): Line 371: try: Line 372: self.log.debug("desktopLogoff called") -- To view, visit http://gerrit.ovirt.org/27147 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1c65304319df949795ec0906df1343a43129641 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
