Dan Kenigsberg has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices ......................................................................
Patch Set 13: Code-Review-1 (3 comments) pardon my laziness, but I find it important to keep this complex patchset as simple as possible. http://gerrit.ovirt.org/#/c/27215/13/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1762: devices[VIDEO_DEVICES] = self.getConfVideo() Line 1763: devices[GRAPHICS_DEVICES] = self.getConfGraphics() Line 1764: devices[CONTROLLER_DEVICES] = self.getConfController() Line 1765: else: Line 1766: if 'display' in self.conf: is the move of the code to is significant? Line 1767: devices[GRAPHICS_DEVICES] = self.getConfGraphics() Line 1768: Line 1769: for dev in self.conf.get('devices'): Line 1770: try: Line 1815: for device in (WATCHDOG_DEVICES, CONSOLE_DEVICES): Line 1816: if len(devices[device]) > 1: Line 1817: raise ValueError("only a single %s device is " Line 1818: "supported" % device) Line 1819: graphDevs = set() In this patch (further down) the same graphDevs variable name is used for something completely different. Unless I am confused, graphDevDisplayTypes is a more exact name. Line 1820: for dev in devices[GRAPHICS_DEVICES]: Line 1821: if dev.get('device') not in graphDevs: Line 1822: graphDevs.add(dev.get('device')) Line 1823: else: Line 2966: self.setDownStatus(ERROR, vmexitreason.LIBVIRT_START_FAILED) Line 2967: return Line 2968: self._domDependentInit() Line 2969: Line 2970: def _updateDevices(self, devices): this part only moves code to a function, and as such could be split to another patch, which could be merged first with next-to-zero worries. BTW, it's an over-complex way to write self.conf['devices'] = reduce(extend, devices.values()) but that's besides the point. Line 2971: """ Line 2972: Update self.conf with updated devices Line 2973: For old type vmParams, new 'devices' key will be Line 2974: created with all devices info -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
