Francesco Romani has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices ......................................................................
Patch Set 15: (1 comment) Addressed reviewer's remark either with code changes (most of time) or with inline code comments/docstrings. Preliminary verifications seems OK (migrations/recovery), more tests still in progress, thus not ticking verified. http://gerrit.ovirt.org/#/c/27215/15/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1877: """ Line 1878: Normalize graphics device provided by conf. Line 1879: """ Line 1880: graphDevs = [] Line 1881: if 'display' in self.conf: To be forward-compatible with future engine which will just send graphic devices. However a few changes are still needed, getConfVideo is just the first which comes to mind. Line 1882: graphDevs.append({ Line 1883: 'type': GRAPHICS_DEVICES, Line 1884: 'device': 'spice' if self.conf['display'] == 'qxl' Line 1885: else 'vnc', -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
