Michal Skrivanek has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/27215/13/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1762: devices[VIDEO_DEVICES] = self.getConfVideo() Line 1763: devices[GRAPHICS_DEVICES] = self.getConfGraphics() Line 1764: devices[CONTROLLER_DEVICES] = self.getConfController() Line 1765: else: Line 1766: if 'display' in self.conf: > is the move of the code to is significant? I think the move of the new legacy-handling code here where we already handle the pre-3.1 legacy makes sense. Should be kept together (and when it grows further should be split out to a dedicated function) Line 1767: devices[GRAPHICS_DEVICES] = self.getConfGraphics() Line 1768: Line 1769: for dev in self.conf.get('devices'): Line 1770: try: -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
