Francesco Romani has posted comments on this change. Change subject: virt: graphdev: add the GraphicsDevice class ......................................................................
Patch Set 22: (1 comment) http://gerrit.ovirt.org/#/c/26895/22/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4376: @property Line 4377: def hasSpice(self): Line 4378: return any( Line 4379: dev['device'] == 'spice' Line 4380: for dev in self.conf.get('devices', self.getConfGraphics()) > Same problem as line 2654. Will fix in a separate followup patch fixed in http://gerrit.ovirt.org/#/c/27596/1 Line 4381: if dev['type'] == GRAPHICS_DEVICES) Line 4382: Line 4383: def _getPid(self): Line 4384: pid = '0' -- To view, visit http://gerrit.ovirt.org/26895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
