Francesco Romani has posted comments on this change.

Change subject: virt: graphdev: add the GraphicsDevice class
......................................................................


Patch Set 23: Verified+1

Vetrified with http://gerrit.ovirt.org/#/c/27595/ , 
http://gerrit.ovirt.org/#/c/27596/ and http://gerrit.ovirt.org/#/c/27215/

Verification (all the following using unpatched engine 3.5.0 snapshot:
* creation flow: booted a VM, connected with spice
* recovery: booted a VM, restarted VDSM, connected with spice
* migration: migrated back and forth another host running VDSM 4.14.8.1
* hibernate:  booted a VM, restarted and connected with spice.
* verified the output of vdsClient
* cursory look at vdsm logs and to engine logs seems OK.

Found
Received a spice Device without an address when processing VM 
025d59e3-f12c-41b8-be3f-de8dc22d23ce devices, skipping device: {port=5900, 
specParams={keyMap=en-us, copyPasteEnable=false, displayIp=0, 
fileTransferEnable=false}, device=spice, type=graphics}

but that is expected since the graphics device do not have PCI addresses.

-- 
To view, visit http://gerrit.ovirt.org/26895
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to