Adam Litke has posted comments on this change. Change subject: LiveMerge: Add block job info to VM stats ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/26634/4/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 161: ('vm_sample_net_window', '2', None), Line 162: Line 163: ('vm_sample_jobs_interval', '15', None), Line 164: Line 165: ('vm_sample_jobs_window', '2', None), > Have you tried with 1? In theory this should be 1 but I don't know if it br I tried that first, but it didn't seem to work with 1 slot. Line 166: Line 167: ('trust_store_path', '@TRUSTSTORE@', Line 168: 'Where the certificates and keys are situated.'), Line 169: http://gerrit.ovirt.org/#/c/26634/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4853: ret = self._dom.blockJobInfo(dev['name'], 0) Line 4854: if not ret: Line 4855: self.log.debug("Block Job for vm:%s, img:%s has ended", Line 4856: self.conf['vmId'], dev['imageID']) Line 4857: self._vm.setDiskBlockJob(dev, None) > I needed a little to understand this, maybe using clearDiskBlockJob is clea Sure, I can add a wrapper function that passes None into setDiskBlockJob for clarity. Line 4858: continue Line 4859: Line 4860: jobID = job['jobID'] Line 4861: jobs[jobID] = {'id': jobID, 'jobType': 'block', -- To view, visit http://gerrit.ovirt.org/26634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7278c0f06a2a06c8a8d680cf64746de3f73a389 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
