Federico Simoncelli has posted comments on this change. Change subject: LiveMerge: Add block job info to VM stats ......................................................................
Patch Set 5: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/26634/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5156: with self._jobsLock: Line 5157: jobs = {} Line 5158: for jobID, job in self.conf['_blockJobs'].items(): Line 5159: drive = self._findDriveByUUIDs(job['disk']) Line 5160: ret = self._dom.blockJobInfo(drive.name, 0) Is it possible to have the libvirt interaction outside of the lock? Collect data first and then commit it later with untrackBlockJob (under the lock). If you don't want to lose time verifying it send another patch on top of this one (maybe using a topic: livemerge-fixes). Line 5161: if not ret: Line 5162: self.log.debug("Block Job for vm:%s, img:%s has ended", Line 5163: self.conf['vmId'], job['disk']['imageID']) Line 5164: self.untrackBlockJob(jobID) -- To view, visit http://gerrit.ovirt.org/26634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7278c0f06a2a06c8a8d680cf64746de3f73a389 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
