Adam Litke has posted comments on this change. Change subject: LiveMerge: Add block job info to VM stats ......................................................................
Patch Set 5: (6 comments) http://gerrit.ovirt.org/#/c/26634/5/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 6105: # @unknown: An unrecognized or unsupported job Line 6106: # Line 6107: # @block: A block job Line 6108: # Line 6109: # Since: 4.14.4 > 4.15.0, I think Done Line 6110: ## Line 6111: {'enum': 'JobType', 'data': ['unknown', 'block']} Line 6112: Line 6113: ## Line 6122: # @copy: A blockCopy operation Line 6123: # Line 6124: # @commit: A blockCommit operation (backward merge) Line 6125: # Line 6126: # Since: 4.14.4 > ditto Done Line 6127: ## Line 6128: {'enum': 'BlockJobType', 'data': ['unknown', 'pull', 'copy', 'commit']} Line 6129: Line 6130: ## Line 6145: # @bandwidth: I/O limit in MB/s (zero means no limit) Line 6146: # Line 6147: # @imgUUID: The UUID of the image on which this job is operating Line 6148: # Line 6149: # Since: 4.14.4 > ditto Done Line 6150: ## Line 6151: {'type': 'BlockJobInfo', Line 6152: 'data': {'id': 'UUID', 'jobType': 'JobType', 'blockJobType': 'BlockJobType', Line 6153: 'cur': 'int', 'end': 'int', 'bandwidth': 'int', 'imgUUID': 'UUID'}} Line 6160: # @id: An ID that was associated with the job when it was started Line 6161: # Line 6162: # @jobType: The general job type Line 6163: # Line 6164: # Since: 4.14.4 > ditto Done Line 6165: ## Line 6166: {'type': 'VmJobInfo', 'data': {'id': 'UUID', 'jobType': 'JobType'}, Line 6167: 'union': ['BlockJobInfo']} Line 6168: Line 6170: # @VmJobsMap: Line 6171: # Line 6172: # A mapping of VM job information indexed by job UUID. Line 6173: # Line 6174: # Since: 4.14.4 > ditto Done Line 6175: ## Line 6176: {'map': 'VmJobsMap', 'key': 'UUID', 'value': 'VmJobInfo'} Line 6177: Line 6178: ## Line 6252: # Line 6253: # @displayInfo: Display and graphics device informations. Line 6254: # (new in version 4.15.0) Line 6255: # Line 6256: # @vmJobs: #optional Info about active vm jobs > please add '(new in version 4.15.0)' Done Line 6257: # Line 6258: # Since: 4.10.0 Line 6259: ## Line 6260: {'type': 'RunningVmStats', -- To view, visit http://gerrit.ovirt.org/26634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7278c0f06a2a06c8a8d680cf64746de3f73a389 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
