Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: xmlrpc protocol detection ......................................................................
Patch Set 5: -Code-Review (1 comment) http://gerrit.ovirt.org/#/c/28507/5/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 257: """ Line 258: Code below was part of SimpleXMLRPCServer.SimpleXMLRPCServer. Line 259: We need this code here in order to construct our ConnectedTCPServer Line 260: which let us provide connected sockets during runtime. Line 261: """ > This docstring is useless. It may be needed on the ConnectedTCPServer class yeah, it's not the best of docstrings. it can be dropped to allow longer rethinking. All that I absolutely request is a comment: # code taken from Python 2.7's SimpleXMLRPCServer.SimpleXMLRPCServer.__init__. Line 262: allow_reuse_address = True Line 263: Line 264: def __init__(self, requestHandler=SimpleXMLRPCRequestHandler, Line 265: logRequests=True, allow_none=False, encoding=None): -- To view, visit http://gerrit.ovirt.org/28507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72819cc0ab5bde0150456263ab7dd1a5e99abfeb Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
