Nir Soffer has posted comments on this change. Change subject: jsonrpc: xmlrpc protocol detection ......................................................................
Patch Set 6: Code-Review+1 (1 comment) There is another instance calling optional arguments in positional style. Can be fixed later if we are in a rush. http://gerrit.ovirt.org/#/c/28507/6/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 261: def __init__(self, requestHandler, logRequests=True, allow_none=False, Line 262: encoding=None): Line 263: self.logRequests = logRequests Line 264: Line 265: SimpleXMLRPCDispatcher.__init__(self, allow_none, encoding) Method signature is: def __init__(self, allow_none=False, encoding=None): So you should call this as: SimpleXMLRPCDispatcher.__init__(self, allow_none=allow_none, encoding=encoding) Yes, I know you copied it from line 592 of SimpleXMLRPCServer.py, Python standard library includes some bad code. Line 266: ConnectedTCPServer.__init__(self, requestHandler) Line 267: Line 268: Line 269: class IPXMLRPCServer(ConnectedSimpleXmlRPCServer): -- To view, visit http://gerrit.ovirt.org/28507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72819cc0ab5bde0150456263ab7dd1a5e99abfeb Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
